Commit b83e45fd authored by Jason A. Donenfeld's avatar Jason A. Donenfeld
Browse files

random: mix in cycle counter when jitter timer fires 



Rather than just relying on interaction between cache lines of the timer
and the main loop, also explicitly take into account the fact that the
timer might fire at some time that's hard to predict, due to scheduling,
interrupts, or cross-CPU conditions. Mix in a cycle counter during the
firing of the timer, in addition to the existing one during the
scheduling of the timer. It can't hurt and can only help.

Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
parent 1c21fe00

drivers/char/random.c

+2 −0
Original line number Diff line number Diff line
@@ -1251,7 +1251,9 @@ struct entropy_timer_state { 
static void __cold entropy_timer(struct timer_list *timer)

{

	struct entropy_timer_state *state = container_of(timer, struct entropy_timer_state, timer);

	unsigned long entropy = random_get_entropy();



	mix_pool_bytes(&entropy, sizeof(entropy));

	if (atomic_inc_return(&state->samples) % state->samples_per_bit == 0)

		credit_init_bits(1);

}