Commit b85e285e authored by Yang Yingliang's avatar Yang Yingliang Committed by Alex Deucher
Browse files

drm/amdgpu: fix pci device refcount leak 



As comment of pci_get_domain_bus_and_slot() says, it returns
a pci device with refcount increment, when finish using it,
the caller must decrement the reference count by calling
pci_dev_put().

So before returning from amdgpu_device_resume|suspend_display_audio(),
pci_dev_put() is called to avoid refcount leak.

Fixes: 3f12acc8 ("drm/amdgpu: put the audio codec into suspend state before gpu reset V3")
Reviewed-by: default avatarEvan Quan <evan.quan@amd.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 96e1a88f

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

+4 −0
Original line number Diff line number Diff line
@@ -5045,6 +5045,8 @@ static void amdgpu_device_resume_display_audio(struct amdgpu_device *adev) 
		pm_runtime_enable(&(p->dev));

		pm_runtime_resume(&(p->dev));

	}



	pci_dev_put(p);

}



static int amdgpu_device_suspend_display_audio(struct amdgpu_device *adev)
@@ -5083,6 +5085,7 @@ static int amdgpu_device_suspend_display_audio(struct amdgpu_device *adev) 


		if (expires < ktime_get_mono_fast_ns()) {

			dev_warn(adev->dev, "failed to suspend display audio\n");

			pci_dev_put(p);

			/* TODO: abort the succeeding gpu reset? */

			return -ETIMEDOUT;

		}
@@ -5090,6 +5093,7 @@ static int amdgpu_device_suspend_display_audio(struct amdgpu_device *adev) 


	pm_runtime_disable(&(p->dev));



	pci_dev_put(p);

	return 0;

}