Commit b9dad156 authored Jun 06, 2023 by Zhen Lei Committed by Vlastimil Babka Jun 06, 2023

mm/slab_common: reduce an if statement in create_cache()



Move the 'out:' statement block out of the successful path to avoid
redundant check on 'err'. The value of 'err' is always zero on success
and negative on failure.

No functional changes, no performance improvements, just a little more
readability.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>

parent d2e527f0

mm/slab_common.c

+2 −4

Original line number	Original line	Diff line number	Diff line
	@@ -236,14 +236,12 @@ static struct kmem_cache create_cache(const char name,

	s->refcount = 1;		s->refcount = 1;
	list_add(&s->list, &slab_caches);		list_add(&s->list, &slab_caches);
	out:
	if (err)
	return ERR_PTR(err);
	return s;		return s;

	out_free_cache:		out_free_cache:
	kmem_cache_free(kmem_cache, s);		kmem_cache_free(kmem_cache, s);
	goto out;		out:
			return ERR_PTR(err);
	}		}

	/**		/**