Commit ba3a5ddc authored by José Expósito's avatar José Expósito Committed by Daniel Vetter
Browse files

drm/selftests/test-drm_dp_mst_helper: Fix memory leak in sideband_msg_req_encode_decode 



Avoid leaking the "out" variable if it is not possible to allocate
the "txmsg" variable.

Fixes: 09234b88 ("drm/selftests/test-drm_dp_mst_helper: Move 'sideband_msg_req_encode_decode' onto the heap")
Addresses-Coverity-ID: 1475685 ("Resource leak")
Signed-off-by: default avatarJosé Expósito <jose.exposito89@gmail.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220108165812.46797-1-jose.exposito89@gmail.com
parent 8de223b9

drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c

+3 −1
Original line number Diff line number Diff line
@@ -131,8 +131,10 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) 
		return false;



	txmsg = kzalloc(sizeof(*txmsg), GFP_KERNEL);

	if (!txmsg)

	if (!txmsg) {

		kfree(out);

		return false;

	}



	drm_dp_encode_sideband_req(in, txmsg);

	ret = drm_dp_decode_sideband_req(txmsg, out);