Commit ba952824 authored by Keith Busch's avatar Keith Busch Committed by Bjorn Helgaas
Browse files

PCI/portdrv: Report reset for frozen channel 

The PCI error recovery always resets the link for a frozen state, so the
port driver should return that a reset is required for its result. This
will get the .slot_reset() callback invoked, which is necessary to
restore the port's config space. Without this, the driver had been
relying on downstream drivers to return this status.

Link: https://lore.kernel.org/r/20210104230300.1277180-6-kbusch@kernel.org


Tested-by: default avatarHedi Berriche <hedi.berriche@hpe.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarHedi Berriche <hedi.berriche@hpe.com>
parent 33ac78bd

drivers/pci/pcie/portdrv_pci.c

+2 −1
Original line number Diff line number Diff line
@@ -153,7 +153,8 @@ static void pcie_portdrv_remove(struct pci_dev *dev) 
static pci_ers_result_t pcie_portdrv_error_detected(struct pci_dev *dev,

					pci_channel_state_t error)

{

	/* Root Port has no impact. Always recovers. */

	if (error == pci_channel_io_frozen)

		return PCI_ERS_RESULT_NEED_RESET;

	return PCI_ERS_RESULT_CAN_RECOVER;

}