Commit bafb1eac authored by Richard Fitzgerald's avatar Richard Fitzgerald Committed by Vinod Koul
Browse files

soundwire: cadence: Simplify error paths in cdns_xfer_msg() 



There's no need to goto an exit label to return from cdns_xfer_msg().
It doesn't do any cleanup, only a return statement.

Replace the gotos with returns.

Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220917154822.690472-2-rf@opensource.cirrus.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 7f6bad4d

drivers/soundwire/cadence_master.c

+4 −7
Original line number Diff line number Diff line
@@ -709,17 +709,14 @@ cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg) 
		ret = _cdns_xfer_msg(cdns, msg, cmd, i * CDNS_MCP_CMD_LEN,

				     CDNS_MCP_CMD_LEN, false);

		if (ret != SDW_CMD_OK)

			goto exit;

			return ret;

	}



	if (!(msg->len % CDNS_MCP_CMD_LEN))

		goto exit;

		return SDW_CMD_OK;



	ret = _cdns_xfer_msg(cdns, msg, cmd, i * CDNS_MCP_CMD_LEN,

	return _cdns_xfer_msg(cdns, msg, cmd, i * CDNS_MCP_CMD_LEN,

			      msg->len % CDNS_MCP_CMD_LEN, false);



exit:

	return ret;

}

EXPORT_SYMBOL(cdns_xfer_msg);