Commit bbaa9c10 authored by Niu Yawei's avatar Niu Yawei Committed by Greg Kroah-Hartman
Browse files

staging/lustre/llite: deny non-root user for changelog operations 



To avoid potential security problems, non-privileged users should
have no permission to run 'lfs changelog' & 'lfs changelog_clear'.

Signed-off-by: default avatarNiu Yawei <yawei.niu@intel.com>
Reviewed-on: http://review.whamcloud.com/14280
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6415


Reviewed-by: default avatarLai Siyao <lai.siyao@intel.com>
Reviewed-by: default avatarJinshan Xiong <jinshan.xiong@intel.com>
Signed-off-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ced41eba

drivers/staging/lustre/lustre/llite/dir.c

+3 −0
Original line number Diff line number Diff line
@@ -1734,6 +1734,9 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg) 
	}

	case OBD_IOC_CHANGELOG_SEND:

	case OBD_IOC_CHANGELOG_CLEAR:

		if (!capable(CFS_CAP_SYS_ADMIN))

			return -EPERM;



		rc = copy_and_ioctl(cmd, sbi->ll_md_exp, (void *)arg,

				    sizeof(struct ioc_changelog));

		return rc;