Commit bc5b749a authored by Aya Mahfouz's avatar Aya Mahfouz Committed by Greg Kroah-Hartman
Browse files

staging: rtl8712: rewrite the right hand side of an assignment 



This patch rewrites the right hand side of an assignment for
expressions of the form:
a = (a <op> b);
to be:
a <op>= b;
where <op> = << | >>.

This issue was detected and resolved using the following
coccinelle script:

@@
identifier i;
expression e;
@@

-i = (i >> e);
+i >>= e;

@@
identifier i;
expression e;
@@

-i = (i << e);
+i <<= e;

Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cb329d83

drivers/staging/rtl8712/rtl871x_eeprom.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -64,7 +64,7 @@ static void shift_out_bits(struct _adapter *padapter, u16 data, u16 count) 
		udelay(CLOCK_RATE);

		udelay(CLOCK_RATE);

		up_clk(padapter, &x);

		up_clk(padapter, &x);

		down_clk(padapter, &x);

		down_clk(padapter, &x);

		mask = mask >> 1;

		mask >>= 1;

	} while (mask);

	} while (mask);

	if (padapter->bSurpriseRemoved == true)

	if (padapter->bSurpriseRemoved == true)

		goto out;

		goto out;
@@ -83,7 +83,7 @@ static u16 shift_in_bits(struct _adapter *padapter) 
	x &= ~(_EEDO | _EEDI);

	x &= ~(_EEDO | _EEDI);

	d = 0;

	d = 0;

	for (i = 0; i < 16; i++) {

	for (i = 0; i < 16; i++) {

		d = d << 1;

		d <<= 1;

		up_clk(padapter, &x);

		up_clk(padapter, &x);

		if (padapter->bSurpriseRemoved == true)

		if (padapter->bSurpriseRemoved == true)

			goto out;

			goto out;