Commit bcda4c86 authored by Ziqi Zhao's avatar Ziqi Zhao Committed by Shuah Khan
Browse files

selftest: pidfd: Omit long and repeating outputs 



An output message:

> # # waitpid WEXITSTATUS=0

will be printed for 30,000+ times in the `pidfd_test` selftest, which
does not seem ideal. This patch removes the print logic in the
`wait_for_pid` function, so each call to this function does not output
a line by default. Any existing call sites where the extra line might
be beneficial have been modified to include extra print statements
outside of the function calls.

Signed-off-by: default avatarZiqi Zhao <astrajoan@yahoo.com>
Reviewed-by: default avatarChristian Brauner <brauner@kernel.org>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent f6a01213

tools/testing/selftests/pidfd/pidfd.h

+0 −1
Original line number Diff line number Diff line
@@ -90,7 +90,6 @@ static inline int wait_for_pid(pid_t pid) 
	}



	ret = WEXITSTATUS(status);

	ksft_print_msg("waitpid WEXITSTATUS=%d\n", ret);

	return ret;

}

tools/testing/selftests/pidfd/pidfd_fdinfo_test.c

+1 −0
Original line number Diff line number Diff line
@@ -143,6 +143,7 @@ static inline int child_join(struct child *child, struct error *err) 
		r = -1;

	}



	ksft_print_msg("waitpid WEXITSTATUS=%d\n", r);

	return r;

}

tools/testing/selftests/pidfd/pidfd_test.c

+2 −1
Original line number Diff line number Diff line
@@ -115,7 +115,8 @@ static int test_pidfd_send_signal_exited_fail(void) 


	pidfd = open(buf, O_DIRECTORY | O_CLOEXEC);



	(void)wait_for_pid(pid);

	ret = wait_for_pid(pid);

	ksft_print_msg("waitpid WEXITSTATUS=%d\n", ret);



	if (pidfd < 0)

		ksft_exit_fail_msg(