Commit bd0a62a6 authored by Roger Lu's avatar Roger Lu Committed by Matthias Brugger
Browse files

soc: mediatek: mtk-svs: add thermal voltage compensation if needed 



Some extreme test environment may keep IC temperature very low or very high
during system boot stage. For stability concern, we add thermal voltage
compenstation if needed no matter svs bank phase is in init02 or mon mode.

Signed-off-by: default avatarRoger Lu <roger.lu@mediatek.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230202124104.16504-4-roger.lu@mediatek.com


Signed-off-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
parent edecdccc

drivers/soc/mediatek/mtk-svs.c

+9 −8
Original line number Diff line number Diff line
@@ -558,7 +558,7 @@ static int svs_adjust_pm_opp_volts(struct svs_bank *svsb) 
	}



	/* Get thermal effect */

	if (svsb->phase == SVSB_PHASE_MON) {

	if (!IS_ERR_OR_NULL(svsb->tzd)) {

		ret = thermal_zone_get_temp(svsb->tzd, &tzone_temp);

		if (ret || (svsb->temp > SVSB_TEMP_UPPER_BOUND &&

			    svsb->temp < SVSB_TEMP_LOWER_BOUND)) {
@@ -573,7 +573,8 @@ static int svs_adjust_pm_opp_volts(struct svs_bank *svsb) 
			temp_voffset += svsb->tzone_ltemp_voffset;



		/* 2-line bank update all opp volts when running mon mode */

		if (svsb->type == SVSB_HIGH || svsb->type == SVSB_LOW) {

		if (svsb->phase == SVSB_PHASE_MON && (svsb->type == SVSB_HIGH ||

						      svsb->type == SVSB_LOW)) {

			opp_start = 0;

			opp_stop = svsb->opp_count;

		}
@@ -589,11 +590,6 @@ static int svs_adjust_pm_opp_volts(struct svs_bank *svsb) 
			/* do nothing */

			goto unlock_mutex;

		case SVSB_PHASE_INIT02:

			svsb_volt = max(svsb->volt[i], svsb->vmin);

			opp_volt = svs_bank_volt_to_opp_volt(svsb_volt,

							     svsb->volt_step,

							     svsb->volt_base);

			break;

		case SVSB_PHASE_MON:

			svsb_volt = max(svsb->volt[i] + temp_voffset, svsb->vmin);

			opp_volt = svs_bank_volt_to_opp_volt(svsb_volt,
@@ -1683,7 +1679,7 @@ static int svs_bank_resource_setup(struct svs_platform *svsp) 
			}

		}



		if (svsb->mode_support & SVSB_MODE_MON) {

		if (!IS_ERR_OR_NULL(svsb->tzone_name)) {

			svsb->tzd = thermal_zone_get_zone_by_name(svsb->tzone_name);

			if (IS_ERR(svsb->tzd)) {

				dev_err(svsb->dev, "cannot get \"%s\" thermal zone\n",
@@ -2122,6 +2118,7 @@ static struct svs_bank svs_mt8192_banks[] = { 
		.type			= SVSB_LOW,

		.set_freq_pct		= svs_set_bank_freq_pct_v3,

		.get_volts		= svs_get_bank_volts_v3,

		.tzone_name		= "gpu1",

		.volt_flags		= SVSB_REMOVE_DVTFIXED_VOLT,

		.mode_support		= SVSB_MODE_INIT02,

		.opp_count		= MAX_OPP_ENTRIES,
@@ -2139,6 +2136,10 @@ static struct svs_bank svs_mt8192_banks[] = { 
		.core_sel		= 0x0fff0100,

		.int_st			= BIT(0),

		.ctl0			= 0x00540003,

		.tzone_htemp		= 85000,

		.tzone_htemp_voffset	= 0,

		.tzone_ltemp		= 25000,

		.tzone_ltemp_voffset	= 7,

	},

	{

		.sw_id			= SVSB_GPU,