Commit be20b96b authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Martin K. Petersen
Browse files

scsi: mac53c94: Fix warning comparing pointer to 0 

Fix the following coccicheck warning:

./drivers/scsi/mac53c94.c:470:29-30: WARNING comparing pointer to 0.
./drivers/scsi/mac53c94.c:349:12-13: WARNING comparing pointer to 0.

Link: https://lore.kernel.org/r/1615349771-81106-1-git-send-email-jiapeng.chong@linux.alibaba.com


Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 973c9208

drivers/scsi/mac53c94.c

+7 −6
Original line number Diff line number Diff line
@@ -346,7 +346,7 @@ static void cmd_done(struct fsc_state *state, int result) 
	struct scsi_cmnd *cmd;



	cmd = state->current_req;

	if (cmd != 0) {

	if (cmd) {

		cmd->result = result;

		(*cmd->scsi_done)(cmd);

		state->current_req = NULL;
@@ -467,12 +467,13 @@ static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *mat 
       	dma_cmd_space = kmalloc_array(host->sg_tablesize + 2,

					     sizeof(struct dbdma_cmd),

					     GFP_KERNEL);

       	if (dma_cmd_space == 0) {

	if (!dma_cmd_space) {

		printk(KERN_ERR "mac53c94: couldn't allocate dma "

		       "command space for %pOF\n", node);

		rc = -ENOMEM;

		goto out_free;

	}



	state->dma_cmds = (struct dbdma_cmd *)DBDMA_ALIGN(dma_cmd_space);

	memset(state->dma_cmds, 0, (host->sg_tablesize + 1)

	       * sizeof(struct dbdma_cmd));