Commit be77bb3e authored by Matthew Auld's avatar Matthew Auld
Browse files

drm/i915/buddy: sanity check the size 



Ensure we check that the size is compatible with the requested
page_size. For tiny objects that are automatically annotated with
TTM_PL_FLAG_CONTIGUOUS(since they fit within a single page), we
currently end up silently overriding the min_page_size, which ends up
hiding bugs elsewhere.

Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
Reviewed-by: default avatarNirmoy Das <nirmoy.das@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220420181613.70033-2-matthew.auld@intel.com
parent a7ce8f82

drivers/gpu/drm/i915/i915_ttm_buddy_manager.c

+1 −0
Original line number Diff line number Diff line
@@ -70,6 +70,7 @@ static int i915_ttm_buddy_man_alloc(struct ttm_resource_manager *man, 
		min_page_size = bo->page_alignment << PAGE_SHIFT;



	GEM_BUG_ON(min_page_size < mm->chunk_size);

	GEM_BUG_ON(!IS_ALIGNED(size, min_page_size));



	if (place->fpfn + bman_res->base.num_pages != place->lpfn &&

	    place->flags & TTM_PL_FLAG_CONTIGUOUS) {