Unverified Commit beed115c authored Apr 11, 2023 by Aashish Sharma Committed by Mark Brown Apr 11, 2023

ASoC: mediatek: common: Fix refcount leak in parse_dai_link_info



Add missing of_node_put()s before the returns to balance
of_node_get()s and of_node_put()s, which may get unbalanced
in case the for loop 'for_each_available_child_of_node' returns
early.

Fixes: 4302187d ("ASoC: mediatek: common: add soundcard driver common code")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@inria.fr>
Link: https://lore.kernel.org/r/202304090504.2K8L6soj-lkp@intel.com/


Signed-off-by: Aashish Sharma <shraash@google.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Trevor Wu <trevor.wu@mediatek.com>
Link: https://lore.kernel.org/r/20230411003431.4048700-1-shraash@google.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent faf15233

sound/soc/mediatek/common/mtk-soundcard-driver.c

+9 −3

Original line number	Diff line number	Diff line
		@@ -47,21 +47,27 @@ int parse_dai_link_info(struct snd_soc_card *card)
		/* Loop over all the dai link sub nodes */
		for_each_available_child_of_node(dev->of_node, sub_node) {
		if (of_property_read_string(sub_node, "link-name",
		&dai_link_name))
		&dai_link_name)) {
		of_node_put(sub_node);
		return -EINVAL;
		}

		for_each_card_prelinks(card, i, dai_link) {
		if (!strcmp(dai_link_name, dai_link->name))
		break;
		}

		if (i >= card->num_links)
		if (i >= card->num_links) {
		of_node_put(sub_node);
		return -EINVAL;
		}

		ret = set_card_codec_info(card, sub_node, dai_link);
		if (ret < 0)
		if (ret < 0) {
		of_node_put(sub_node);
		return ret;
		}
		}

		return 0;
		}