Commit c002f04c authored by Eli Billauer's avatar Eli Billauer Committed by Greg Kroah-Hartman
Browse files

char: xillybus: Fix trivial bug with mutex 



@unit_mutex protects @unit from being freed, so obviously it should be
released after @unit is used, and not before.

This is a follow-up to commit 282a4b71 ("char: xillybus: Prevent
use-after-free due to race condition") which ensures, among others, the
protection of @private_data after @unit_mutex has been released.

Reported-by: default avatarHyunwoo Kim <imv4bel@gmail.com>
Signed-off-by: default avatarEli Billauer <eli.billauer@gmail.com>
Link: https://lore.kernel.org/r/20221117071825.3942-1-eli.billauer@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0ef77698

drivers/char/xillybus/xillybus_class.c

+4 −3
Original line number Diff line number Diff line
@@ -227,14 +227,15 @@ int xillybus_find_inode(struct inode *inode, 
			break;

		}



	if (!unit) {

		mutex_unlock(&unit_mutex);



	if (!unit)

		return -ENODEV;

	}



	*private_data = unit->private_data;

	*index = minor - unit->lowest_minor;



	mutex_unlock(&unit_mutex);

	return 0;

}

EXPORT_SYMBOL(xillybus_find_inode);