Commit c0b63034 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/geode/gx1fb: Use fbdev I/O helpers 



Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
	* use _IOMEM_ in commit message
v2:
	* updated to use _IOMEM_ tokens

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarHelge Deller <deller@gmx.de>
Cc: Andres Salomon <dilinger@queued.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-14-tzimmermann@suse.de
parent 50112608

drivers/video/fbdev/geode/Kconfig

+1 −3
Original line number Diff line number Diff line
@@ -45,9 +45,7 @@ config FB_GEODE_GX 
config FB_GEODE_GX1

	tristate "AMD Geode GX1 framebuffer support"

	depends on FB && FB_GEODE

	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

	select FB_IOMEM_HELPERS

	select VIDEO_NOMODESET

	help

	  Framebuffer driver for the display controller integrated into the

drivers/video/fbdev/geode/gx1fb_core.c

+1 −4
Original line number Diff line number Diff line
@@ -255,14 +255,11 @@ static int parse_panel_option(struct fb_info *info) 


static const struct fb_ops gx1fb_ops = {

	.owner		= THIS_MODULE,

	FB_DEFAULT_IOMEM_OPS,

	.fb_check_var	= gx1fb_check_var,

	.fb_set_par	= gx1fb_set_par,

	.fb_setcolreg	= gx1fb_setcolreg,

	.fb_blank       = gx1fb_blank,

	/* No HW acceleration for now. */

	.fb_fillrect	= cfb_fillrect,

	.fb_copyarea	= cfb_copyarea,

	.fb_imageblit	= cfb_imageblit,

};



static struct fb_info *gx1fb_init_fbinfo(struct device *dev)