Commit c15cbe9a authored by Bart Van Assche's avatar Bart Van Assche Committed by Jens Axboe
Browse files

scsi/device_handlers: Use the new blk_opf_t type 



Improve static type checking by using the new blk_opf_t type for variables
that represent request flags.

Cc: Hannes Reinecke <hare@suse.com>
Cc: Martin Wilck <mwilck@suse.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20220714180729.1065367-43-bvanassche@acm.org


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 2599cac5

drivers/scsi/device_handler/scsi_dh_alua.c

+2 −2
Original line number Diff line number Diff line
@@ -127,7 +127,7 @@ static int submit_rtpg(struct scsi_device *sdev, unsigned char *buff, 
		       int bufflen, struct scsi_sense_hdr *sshdr, int flags)

{

	u8 cdb[MAX_COMMAND_SIZE];

	int req_flags = REQ_FAILFAST_DEV | REQ_FAILFAST_TRANSPORT |

	blk_opf_t req_flags = REQ_FAILFAST_DEV | REQ_FAILFAST_TRANSPORT |

		REQ_FAILFAST_DRIVER;



	/* Prepare the command. */
@@ -157,7 +157,7 @@ static int submit_stpg(struct scsi_device *sdev, int group_id, 
	u8 cdb[MAX_COMMAND_SIZE];

	unsigned char stpg_data[8];

	int stpg_len = 8;

	int req_flags = REQ_FAILFAST_DEV | REQ_FAILFAST_TRANSPORT |

	blk_opf_t req_flags = REQ_FAILFAST_DEV | REQ_FAILFAST_TRANSPORT |

		REQ_FAILFAST_DRIVER;



	/* Prepare the data buffer */

drivers/scsi/device_handler/scsi_dh_emc.c

+1 −1
Original line number Diff line number Diff line
@@ -239,7 +239,7 @@ static int send_trespass_cmd(struct scsi_device *sdev, 
	unsigned char cdb[MAX_COMMAND_SIZE];

	int err, res = SCSI_DH_OK, len;

	struct scsi_sense_hdr sshdr;

	u64 req_flags = REQ_FAILFAST_DEV | REQ_FAILFAST_TRANSPORT |

	blk_opf_t req_flags = REQ_FAILFAST_DEV | REQ_FAILFAST_TRANSPORT |

		REQ_FAILFAST_DRIVER;



	if (csdev->flags & CLARIION_SHORT_TRESPASS) {

drivers/scsi/device_handler/scsi_dh_hp_sw.c

+2 −2
Original line number Diff line number Diff line
@@ -83,7 +83,7 @@ static int hp_sw_tur(struct scsi_device *sdev, struct hp_sw_dh_data *h) 
	unsigned char cmd[6] = { TEST_UNIT_READY };

	struct scsi_sense_hdr sshdr;

	int ret = SCSI_DH_OK, res;

	u64 req_flags = REQ_FAILFAST_DEV | REQ_FAILFAST_TRANSPORT |

	blk_opf_t req_flags = REQ_FAILFAST_DEV | REQ_FAILFAST_TRANSPORT |

		REQ_FAILFAST_DRIVER;



retry:
@@ -121,7 +121,7 @@ static int hp_sw_start_stop(struct hp_sw_dh_data *h) 
	struct scsi_device *sdev = h->sdev;

	int res, rc = SCSI_DH_OK;

	int retry_cnt = HP_SW_RETRIES;

	u64 req_flags = REQ_FAILFAST_DEV | REQ_FAILFAST_TRANSPORT |

	blk_opf_t req_flags = REQ_FAILFAST_DEV | REQ_FAILFAST_TRANSPORT |

		REQ_FAILFAST_DRIVER;



retry:

drivers/scsi/device_handler/scsi_dh_rdac.c

+1 −1
Original line number Diff line number Diff line
@@ -536,7 +536,7 @@ static void send_mode_select(struct work_struct *work) 
	unsigned char cdb[MAX_COMMAND_SIZE];

	struct scsi_sense_hdr sshdr;

	unsigned int data_size;

	u64 req_flags = REQ_FAILFAST_DEV | REQ_FAILFAST_TRANSPORT |

	blk_opf_t req_flags = REQ_FAILFAST_DEV | REQ_FAILFAST_TRANSPORT |

		REQ_FAILFAST_DRIVER;



	spin_lock(&ctlr->ms_lock);