Unverified Commit c1a77ba4 authored Dec 02, 2021 by Andy Shevchenko Committed by Mark Brown Dec 06, 2021

ASoC: ti: davinci-mcasp: Remove unnecessary conditional



Instead of double validating of_node, return value of
the boolean property directly.

We can't remove ifdeffery, because in OF_GPIO=n cases
it might bring unwanted surprises.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/20211202205612.76216-2-andriy.shevchenko@linux.intel.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 4db32072

sound/soc/ti/davinci-mcasp.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -1870,12 +1870,10 @@ static int mcasp_reparent_fck(struct platform_device *pdev)
		static bool davinci_mcasp_have_gpiochip(struct davinci_mcasp *mcasp)
		{
		#ifdef CONFIG_OF_GPIO
		if (mcasp->dev->of_node &&
		of_property_read_bool(mcasp->dev->of_node, "gpio-controller"))
		return true;
		#endif

		return of_property_read_bool(mcasp->dev->of_node, "gpio-controller");
		#else
		return false;
		#endif
		}

		static int davinci_mcasp_get_config(struct davinci_mcasp *mcasp,