Commit c224d049 authored by Ming Qian's avatar Ming Qian Committed by Hans Verkuil
Browse files

media: amphion: fix UNINIT issues reported by coverity 



using uninitialized value may introduce risk

Fixes: 9f599f35 ("media: amphion: add vpu core driver")
Reviewed-by: default avatarNicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: default avatarMing Qian <ming.qian@nxp.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 79d3bafa

drivers/media/platform/amphion/vpu_msgs.c

+6 −6
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ static void vpu_session_handle_start_done(struct vpu_inst *inst, struct vpu_rpc_ 


static void vpu_session_handle_mem_request(struct vpu_inst *inst, struct vpu_rpc_event *pkt)

{

	struct vpu_pkt_mem_req_data req_data;

	struct vpu_pkt_mem_req_data req_data = { 0 };



	vpu_iface_unpack_msg_data(inst->core, pkt, (void *)&req_data);

	vpu_trace(inst->dev, "[%d] %d:%d %d:%d %d:%d\n",
@@ -80,7 +80,7 @@ static void vpu_session_handle_resolution_change(struct vpu_inst *inst, struct v 


static void vpu_session_handle_enc_frame_done(struct vpu_inst *inst, struct vpu_rpc_event *pkt)

{

	struct vpu_enc_pic_info info;

	struct vpu_enc_pic_info info = { 0 };



	vpu_iface_unpack_msg_data(inst->core, pkt, (void *)&info);

	dev_dbg(inst->dev, "[%d] frame id = %d, wptr = 0x%x, size = %d\n",
@@ -90,7 +90,7 @@ static void vpu_session_handle_enc_frame_done(struct vpu_inst *inst, struct vpu_ 


static void vpu_session_handle_frame_request(struct vpu_inst *inst, struct vpu_rpc_event *pkt)

{

	struct vpu_fs_info fs;

	struct vpu_fs_info fs = { 0 };



	vpu_iface_unpack_msg_data(inst->core, pkt, &fs);

	call_void_vop(inst, event_notify, VPU_MSG_ID_FRAME_REQ, &fs);
@@ -107,7 +107,7 @@ static void vpu_session_handle_frame_release(struct vpu_inst *inst, struct vpu_r 
		info.type = inst->out_format.type;

		call_void_vop(inst, buf_done, &info);

	} else if (inst->core->type == VPU_CORE_TYPE_DEC) {

		struct vpu_fs_info fs;

		struct vpu_fs_info fs = { 0 };



		vpu_iface_unpack_msg_data(inst->core, pkt, &fs);

		call_void_vop(inst, event_notify, VPU_MSG_ID_FRAME_RELEASE, &fs);
@@ -122,7 +122,7 @@ static void vpu_session_handle_input_done(struct vpu_inst *inst, struct vpu_rpc_ 


static void vpu_session_handle_pic_decoded(struct vpu_inst *inst, struct vpu_rpc_event *pkt)

{

	struct vpu_dec_pic_info info;

	struct vpu_dec_pic_info info = { 0 };



	vpu_iface_unpack_msg_data(inst->core, pkt, (void *)&info);

	call_void_vop(inst, get_one_frame, &info);
@@ -130,7 +130,7 @@ static void vpu_session_handle_pic_decoded(struct vpu_inst *inst, struct vpu_rpc 


static void vpu_session_handle_pic_done(struct vpu_inst *inst, struct vpu_rpc_event *pkt)

{

	struct vpu_dec_pic_info info;

	struct vpu_dec_pic_info info = { 0 };

	struct vpu_frame_info frame;



	memset(&frame, 0, sizeof(frame));