Commit c25015c1 authored Oct 11, 2012 by Dan Carpenter Committed by Greg Kroah-Hartman Oct 22, 2012

Staging: vt6655-6: shift wrap in hostap_set_encryption()



abySeq is an unsigned char so shifting more than 31 bits will lead to a
shift wrapping bug.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ff4573a7

drivers/staging/vt6655/hostap.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -596,9 +596,9 @@ static int hostap_set_encryption(PSDevice pDevice,

		if (param->u.crypt.seq) {
		memcpy(&abySeq, param->u.crypt.seq, 8);
		for (ii = 0 ; ii < 8 ; ii++) {
		KeyRSC \|= (abySeq[ii] << (ii * 8));
		}
		for (ii = 0 ; ii < 8 ; ii++)
		KeyRSC \|= (unsigned long)abySeq[ii] << (ii * 8);

		dwKeyIndex \|= 1 << 29;
		pMgmt->sNodeDBTable[iNodeIndex].KeyRSC = KeyRSC;
		}

drivers/staging/vt6656/hostap.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -542,9 +542,9 @@ static int hostap_set_encryption(PSDevice pDevice,

		if (param->u.crypt.seq) {
		memcpy(&abySeq, param->u.crypt.seq, 8);
		for (ii = 0 ; ii < 8 ; ii++) {
		KeyRSC \|= (abySeq[ii] << (ii * 8));
		}
		for (ii = 0 ; ii < 8 ; ii++)
		KeyRSC \|= (unsigned long)abySeq[ii] << (ii * 8);

		dwKeyIndex \|= 1 << 29;
		pMgmt->sNodeDBTable[iNodeIndex].KeyRSC = KeyRSC;
		}