Unverified Commit c25d4546 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mark Brown
Browse files

ASoC: Intel: bytcht_es8316: Utilize dev_err_probe() to avoid log saturation 



dev_err_probe() avoids printing into log when the deferred probe is invoked.
This is possible when clock provider is pending to appear.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20211006150428.16434-4-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 10f4a965

sound/soc/intel/boards/bytcht_es8316.c

+5 −13
Original line number Diff line number Diff line
@@ -532,11 +532,8 @@ static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev) 


	/* get the clock */

	priv->mclk = devm_clk_get(dev, "pmc_plt_clk_3");

	if (IS_ERR(priv->mclk)) {

		ret = PTR_ERR(priv->mclk);

		dev_err(dev, "clk_get pmc_plt_clk_3 failed: %d\n", ret);

		return ret;

	}

	if (IS_ERR(priv->mclk))

		return dev_err_probe(dev, PTR_ERR(priv->mclk), "clk_get pmc_plt_clk_3 failed\n");



	/* get speaker enable GPIO */

	codec_dev = acpi_get_first_physical_node(adev);
@@ -570,15 +567,10 @@ static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev) 
				   /* see comment in byt_cht_es8316_resume() */

				   GPIOD_OUT_LOW | GPIOD_FLAGS_BIT_NONEXCLUSIVE);

	if (IS_ERR(priv->speaker_en_gpio)) {

		ret = PTR_ERR(priv->speaker_en_gpio);

		switch (ret) {

		default:

			dev_err(dev, "get speaker GPIO failed: %d\n", ret);

			fallthrough;

		case -EPROBE_DEFER:

		ret = dev_err_probe(dev, PTR_ERR(priv->speaker_en_gpio),

				    "get speaker GPIO failed\n");

		goto err_put_codec;

	}

	}



	snprintf(components_string, sizeof(components_string),

		 "cfg-spk:%s cfg-mic:%s",