Commit c3177cb0 authored Mar 16, 2021 by Robert Foss Committed by Mauro Carvalho Chehab Mar 22, 2021

media: camss: Replace trace_printk() with dev_dbg()



trace_printk() should not be used in production code,
since extra memory is used for special buffers whenever
trace_puts() is used.

Replace it with dev_dbg() which provides all of the desired
debugging functionality.

Signed-off-by: Robert Foss <robert.foss@linaro.org>
Suggested-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent ad46e1a8

drivers/media/platform/qcom/camss/camss-vfe-4-1.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -12,6 +12,7 @@
		#include <linux/io.h>
		#include <linux/iopoll.h>

		#include "camss.h"
		#include "camss-vfe.h"

		#define VFE_0_HW_VERSION 0x000
		@@ -936,7 +937,7 @@ static irqreturn_t vfe_isr(int irq, void *dev)

		vfe->ops->isr_read(vfe, &value0, &value1);

		trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n",
		dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n",
		value0, value1);

		if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK)

drivers/media/platform/qcom/camss/camss-vfe-4-7.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -12,6 +12,7 @@
		#include <linux/io.h>
		#include <linux/iopoll.h>

		#include "camss.h"
		#include "camss-vfe.h"

		#define VFE_0_HW_VERSION 0x000
		@@ -1069,7 +1070,7 @@ static irqreturn_t vfe_isr(int irq, void *dev)

		vfe->ops->isr_read(vfe, &value0, &value1);

		trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n",
		dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n",
		value0, value1);

		if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK)