Commit c3ddac4b authored by Colin Ian King's avatar Colin Ian King Committed by Marc Kleine-Budde
Browse files

can: isotp: padlen(): make const array static, makes object smaller 



Don't populate the const array plen on the stack but instead it static. Makes
the object code smaller by 926 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
  26531	   1943	     64	  28538	   6f7a	net/can/isotp.o

After:
   text	   data	    bss	    dec	    hex	filename
  25509	   2039	     64	  27612	   6bdc	net/can/isotp.o

(gcc version 10.2.0)

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20201020154203.54711-1-colin.king@canonical.com


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 78656ea2

net/can/isotp.c

+10 −8
Original line number Diff line number Diff line
@@ -252,14 +252,16 @@ static void isotp_rcv_skb(struct sk_buff *skb, struct sock *sk) 


static u8 padlen(u8 datalen)

{

	const u8 plen[] = {8, 8, 8, 8, 8, 8, 8, 8, 8,		/* 0 - 8 */

	static const u8 plen[] = {

		8, 8, 8, 8, 8, 8, 8, 8, 8,	/* 0 - 8 */

		12, 12, 12, 12,			/* 9 - 12 */

		16, 16, 16, 16,			/* 13 - 16 */

		20, 20, 20, 20,			/* 17 - 20 */

		24, 24, 24, 24,			/* 21 - 24 */

		32, 32, 32, 32, 32, 32, 32, 32,	/* 25 - 32 */

		48, 48, 48, 48, 48, 48, 48, 48,	/* 33 - 40 */

			   48, 48, 48, 48, 48, 48, 48, 48};	/* 41 - 48 */

		48, 48, 48, 48, 48, 48, 48, 48	/* 41 - 48 */

	};



	if (datalen > 48)

		return 64;