Unverified Commit c4b7174f authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Mark Brown
Browse files

ASoC: mediatek: mt8195: Fix error handling in mt8195_mt6359_rt1019_rt5682_dev_probe 



The device_node pointer is returned by of_parse_phandle()  with refcount
incremented. We should use of_node_put() on it when done.

This function only calls of_node_put() in the regular path.
And it will cause refcount leak in error path.

Fixes: 082482a5 ("ASoC: mediatek: mt8195: release device_node after snd_soc_register_card")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220316084623.24238-1-linmq006@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent abed17fd

sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c

+3 −1
Original line number Diff line number Diff line
@@ -1342,7 +1342,8 @@ static int mt8195_mt6359_rt1019_rt5682_dev_probe(struct platform_device *pdev) 
					      "mediatek,dai-link");

		if (ret) {

			dev_dbg(&pdev->dev, "Parse dai-link fail\n");

			return -EINVAL;

			ret = -EINVAL;

			goto put_node;

		}

	} else {

		if (!sof_on)
@@ -1398,6 +1399,7 @@ static int mt8195_mt6359_rt1019_rt5682_dev_probe(struct platform_device *pdev) 


	ret = devm_snd_soc_register_card(&pdev->dev, card);



put_node:

	of_node_put(platform_node);

	of_node_put(adsp_node);

	of_node_put(dp_node);