Commit c50762a8 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: Remove unused assignments 



Remove variables and assignments that are never used.

Found by Krzysztof using cppcheck, e.g.,

  $ cppcheck --enable=all --force
  uselessAssignmentPtrArg drivers/pci/proc.c:102 Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
  unreadVariable drivers/pci/setup-bus.c:1528 Variable 'old_flags' is assigned a value that is never used.

Reported-by: default avatarKrzysztof Wilczyński <kw@linux.com>
Link: https://lore.kernel.org/r/20220313192933.434746-2-helgaas@kernel.org


Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent cb2d0f84

drivers/pci/pci-sysfs.c

+1 −6
Original line number Diff line number Diff line
@@ -754,8 +754,6 @@ static ssize_t pci_read_config(struct file *filp, struct kobject *kobj, 
		u8 val;

		pci_user_read_config_byte(dev, off, &val);

		data[off - init_off] = val;

		off++;

		--size;

	}



	pci_config_pm_runtime_put(dev);
@@ -818,11 +816,8 @@ static ssize_t pci_write_config(struct file *filp, struct kobject *kobj, 
		size -= 2;

	}



	if (size) {

	if (size)

		pci_user_write_config_byte(dev, off, data[off - init_off]);

		off++;

		--size;

	}



	pci_config_pm_runtime_put(dev);

drivers/pci/proc.c

+0 −4
Original line number Diff line number Diff line
@@ -99,9 +99,7 @@ static ssize_t proc_bus_pci_read(struct file *file, char __user *buf, 
		unsigned char val;

		pci_user_read_config_byte(dev, pos, &val);

		__put_user(val, buf);

		buf++;

		pos++;

		cnt--;

	}



	pci_config_pm_runtime_put(dev);
@@ -176,9 +174,7 @@ static ssize_t proc_bus_pci_write(struct file *file, const char __user *buf, 
		unsigned char val;

		__get_user(val, buf);

		pci_user_write_config_byte(dev, pos, val);

		buf++;

		pos++;

		cnt--;

	}



	pci_config_pm_runtime_put(dev);

drivers/pci/setup-bus.c

+1 −1
Original line number Diff line number Diff line
@@ -1525,7 +1525,7 @@ static void pci_bridge_release_resources(struct pci_bus *bus, 
{

	struct pci_dev *dev = bus->self;

	struct resource *r;

	unsigned int old_flags = 0;

	unsigned int old_flags;

	struct resource *b_res;

	int idx = 1;