Commit c6835e8d authored by Baolin Wang's avatar Baolin Wang Committed by Andrew Morton
Browse files

mm: compaction: remove redundant VM_BUG_ON() in compact_zone() 

Patch series "Some small improvements for compaction".

When I did some compaction testing, I found some small room for
improvement as well as some code cleanups.


This patch (of 5):

The compaction_suitable() will never return values other than
COMPACT_SUCCESS, COMPACT_SKIPPED and COMPACT_CONTINUE, so after validation
of COMPACT_SUCCESS and COMPACT_SKIPPED, we will never hit other unexpected
case.  Thus remove the redundant VM_BUG_ON() validation for the return
values of compaction_suitable().

Link: https://lkml.kernel.org/r/cover.1673342761.git.baolin.wang@linux.alibaba.com
Link: https://lkml.kernel.org/r/740a2396d9b98154dba76e326cba5e798b640ead.1673342761.git.baolin.wang@linux.alibaba.com


Signed-off-by: default avatarBaolin Wang <baolin.wang@linux.alibaba.com>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent baabcfc9

mm/compaction.c

+0 −3
Original line number Diff line number Diff line
@@ -2313,9 +2313,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) 
	if (ret == COMPACT_SUCCESS || ret == COMPACT_SKIPPED)

		return ret;



	/* huh, compaction_suitable is returning something unexpected */

	VM_BUG_ON(ret != COMPACT_CONTINUE);



	/*

	 * Clear pageblock skip if there were failures recently and compaction

	 * is about to be retried after being deferred.