Unverified Commit c6e5e92c authored by Zenghui Yu's avatar Zenghui Yu Committed by Mark Brown
Browse files

regulator: dummy: Use devm_regulator_register() 



debugfs code complained at boot time that

  debugfs: Directory 'reg-dummy-regulator-dummy' with parent 'regulator'
  already present!

if we compile kernel with DEBUG_TEST_DRIVER_REMOVE. The problem is that we
don't provide .remove() method for dummy_regulator_driver, which should
invoke regulator_unregister() on device teardown to properly free things.

Though it's harmless as dummy_pdev never gets unbound in practice, let's
use devm_regulator_register() to get rid of the inconsistency.

Signed-off-by: default avatarZenghui Yu <yuzenghui@huawei.com>
Link: https://lore.kernel.org/r/20210925035507.1904-1-yuzenghui@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e458d3f3

drivers/regulator/dummy.c

+2 −1
Original line number Diff line number Diff line
@@ -45,7 +45,8 @@ static int dummy_regulator_probe(struct platform_device *pdev) 
	config.dev = &pdev->dev;

	config.init_data = &dummy_initdata;



	dummy_regulator_rdev = regulator_register(&dummy_desc, &config);

	dummy_regulator_rdev = devm_regulator_register(&pdev->dev, &dummy_desc,

						       &config);

	if (IS_ERR(dummy_regulator_rdev)) {

		ret = PTR_ERR(dummy_regulator_rdev);

		pr_err("Failed to register regulator: %d\n", ret);