Commit c7c8a8fc authored by Laxman Dewangan's avatar Laxman Dewangan
Browse files

gpio: sx150x: Use devm_gpiochip_add_data() for gpio registration 



Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.

Signed-off-by: default avatarLaxman Dewangan <ldewangan@nvidia.com>
parent 1a20cb2d

drivers/gpio/gpio-sx150x.c

+2 −16
Original line number Diff line number Diff line
@@ -687,7 +687,7 @@ static int sx150x_probe(struct i2c_client *client, 
	if (rc < 0)

		return rc;



	rc = gpiochip_add_data(&chip->gpio_chip, chip);

	rc = devm_gpiochip_add_data(&client->dev, &chip->gpio_chip, chip);

	if (rc)

		return rc;
@@ -696,23 +696,10 @@ static int sx150x_probe(struct i2c_client *client, 
					pdata->irq_summary,

					pdata->irq_base);

		if (rc < 0)

			goto probe_fail_post_gpiochip_add;

	}



	i2c_set_clientdata(client, chip);



	return 0;

probe_fail_post_gpiochip_add:

	gpiochip_remove(&chip->gpio_chip);

			return rc;

	}



static int sx150x_remove(struct i2c_client *client)

{

	struct sx150x_chip *chip;



	chip = i2c_get_clientdata(client);

	gpiochip_remove(&chip->gpio_chip);

	i2c_set_clientdata(client, chip);



	return 0;

}
@@ -723,7 +710,6 @@ static struct i2c_driver sx150x_driver = { 
		.of_match_table = of_match_ptr(sx150x_of_match),

	},

	.probe    = sx150x_probe,

	.remove   = sx150x_remove,

	.id_table = sx150x_id,

};