Commit c80561e9 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

staging: dgnc: UART_IIR_XOFF code is buggy 



The UART_IIR_XOFF was supposed to be a no-op but, because there was a
missing semi-colon, the if statement is not "Empty".  I have just deleted
this code because it was supposed to be a no-op anyway.  UART_IIR_XOFF
is a standard define and not something specific to this driver.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0f33ae1e

drivers/staging/dgnc/dgnc_cls.c

+0 −4
Original line number Diff line number Diff line
@@ -453,10 +453,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, uint port) 
			cls_copy_data_from_queue_to_uart(ch);

		}



		/* Received Xoff signal/Special character */

		if (isr & UART_IIR_XOFF)

			/* Empty */



		/* CTS/RTS change of state */

		if (isr & UART_IIR_CTSRTS) {

			brd->intr_modem++;

drivers/staging/dgnc/dgnc_cls.h

+0 −1
Original line number Diff line number Diff line
@@ -61,7 +61,6 @@ struct cls_uart_struct { 
#define UART_16654_FCR_RXTRIGGER_56	0x80

#define UART_16654_FCR_RXTRIGGER_60     0xC0



#define UART_IIR_XOFF			0x10	/* Received Xoff signal/Special character */

#define UART_IIR_CTSRTS			0x20	/* Received CTS/RTS change of state */

#define UART_IIR_RDI_TIMEOUT		0x0C    /* Receiver data TIMEOUT */