Commit c818ae56 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Linus Walleij
Browse files

pinctrl: rockchip: Fix refcount leak in rockchip_pinctrl_parse_groups 



of_find_node_by_phandle() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: d3e51161 ("pinctrl: add pinctrl driver for Rockchip SoCs")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20230102112845.3982407-1-linmq006@gmail.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent dcef18c8

drivers/pinctrl/pinctrl-rockchip.c

+1 −0
Original line number Diff line number Diff line
@@ -3036,6 +3036,7 @@ static int rockchip_pinctrl_parse_groups(struct device_node *np, 
		np_config = of_find_node_by_phandle(be32_to_cpup(phandle));

		ret = pinconf_generic_parse_dt_config(np_config, NULL,

				&grp->data[j].configs, &grp->data[j].nconfigs);

		of_node_put(np_config);

		if (ret)

			return ret;

	}