Commit c83f320e authored by Ivan Orlov's avatar Ivan Orlov Committed by Shuah Khan
Browse files

selftests: cgroup: Add 'malloc' failures checks in test_memcontrol 



There are several 'malloc' calls in test_memcontrol, which can be
unsuccessful. This patch will add 'malloc' failures checking to
give more details about test's fail reasons and avoid possible
undefined behavior during the future null dereference (like the
one in alloc_anon_50M_check_swap function).

Signed-off-by: default avatarIvan Orlov <ivan.orlov0322@gmail.com>
Reviewed-by: default avatarMuchun Song <songmuchun@bytedance.com>
Acked-by: default avatarShakeel Butt <shakeelb@google.com>
Acked-by: default avatarRoman Gushchin <roman.gushchin@linux.dev>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 350d216d

tools/testing/selftests/cgroup/test_memcontrol.c

+15 −0
Original line number Diff line number Diff line
@@ -98,6 +98,11 @@ static int alloc_anon_50M_check(const char *cgroup, void *arg) 
	int ret = -1;



	buf = malloc(size);

	if (buf == NULL) {

		fprintf(stderr, "malloc() failed\n");

		return -1;

	}



	for (ptr = buf; ptr < buf + size; ptr += PAGE_SIZE)

		*ptr = 0;
@@ -211,6 +216,11 @@ static int alloc_anon_noexit(const char *cgroup, void *arg) 
	char *buf, *ptr;



	buf = malloc(size);

	if (buf == NULL) {

		fprintf(stderr, "malloc() failed\n");

		return -1;

	}



	for (ptr = buf; ptr < buf + size; ptr += PAGE_SIZE)

		*ptr = 0;
@@ -778,6 +788,11 @@ static int alloc_anon_50M_check_swap(const char *cgroup, void *arg) 
	int ret = -1;



	buf = malloc(size);

	if (buf == NULL) {

		fprintf(stderr, "malloc() failed\n");

		return -1;

	}



	for (ptr = buf; ptr < buf + size; ptr += PAGE_SIZE)

		*ptr = 0;