Commit c874ad87 authored by Kang Chen's avatar Kang Chen Committed by Leon Romanovsky
Browse files

IB/hifi1: add a null check of kzalloc_node in hfi1_ipoib_txreq_init 



kzalloc_node may fails, check it and do the cleanup.

Fixes: b1151b74 ("IB/hfi1: Fix alloc failure with larger txqueuelen")
Signed-off-by: default avatarKang Chen <void0red@gmail.com>
Link: https://lore.kernel.org/r/20230227100212.910820-1-void0red@gmail.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent eeac8ede

drivers/infiniband/hw/hfi1/ipoib_tx.c

+4 −1
Original line number Diff line number Diff line
@@ -737,10 +737,13 @@ int hfi1_ipoib_txreq_init(struct hfi1_ipoib_dev_priv *priv) 
		txq->tx_ring.shift = ilog2(tx_item_size);

		txq->tx_ring.avail = hfi1_ipoib_ring_hwat(txq);

		tx_ring = &txq->tx_ring;

		for (j = 0; j < tx_ring_size; j++)

		for (j = 0; j < tx_ring_size; j++) {

			hfi1_txreq_from_idx(tx_ring, j)->sdma_hdr =

				kzalloc_node(sizeof(*tx->sdma_hdr),

					     GFP_KERNEL, priv->dd->node);

			if (!hfi1_txreq_from_idx(tx_ring, j)->sdma_hdr)

				goto free_txqs;

		}



		netif_napi_add_tx(dev, &txq->napi, hfi1_ipoib_poll_tx_ring);

	}