Commit c965daac authored by Maximilian Luz's avatar Maximilian Luz Committed by Hans de Goede
Browse files

platform/surface: aggregator: Add missing call to ssam_request_sync_free() 



Although rare, ssam_request_sync_init() can fail. In that case, the
request should be freed via ssam_request_sync_free(). Currently it is
leaked instead. Fix this.

Fixes: c167b9c7 ("platform/surface: Add Surface Aggregator subsystem")
Signed-off-by: default avatarMaximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20221220175608.1436273-1-luzmaximilian@gmail.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent ae0fa0a3

drivers/platform/surface/aggregator/controller.c

+3 −1
Original line number Diff line number Diff line
@@ -1700,8 +1700,10 @@ int ssam_request_sync(struct ssam_controller *ctrl, 
		return status;



	status = ssam_request_sync_init(rqst, spec->flags);

	if (status)

	if (status) {

		ssam_request_sync_free(rqst);

		return status;

	}



	ssam_request_sync_set_resp(rqst, rsp);