Commit ca3e7d52 authored by Alexandru Ardelean's avatar Alexandru Ardelean Committed by Jonathan Cameron
Browse files

iio: buffer: use sysfs_attr_init() on allocated attrs 

When dynamically allocating sysfs attributes, it's a good idea to call
sysfs_attr_init() on them to initialize lock_class_keys.
This change does that.

The lock_class_keys are set when the CONFIG_DEBUG_LOCK_ALLOC symbol is
enabled. Which is [likely] one reason why I did not see this during
development.

I also am not able to see this even with CONFIG_DEBUG_LOCK_ALLOC enabled,
so this may [likely] be reproduce-able on some system configurations.

This was reported via:
  https://lore.kernel.org/linux-iio/CA+U=DsrsvGgXEF30-vXuXS_k=-mjSjiBwEEzwKb1hJVn1P98OA@mail.gmail.com/T/#u



Fixes: 15097c7a ("iio: buffer: wrap all buffer attributes into iio_dev_attr")
Reported-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: default avatarAlexandru Ardelean <aardelean@deviqon.com>
Link: https://lore.kernel.org/r/20210402174226.630346-1-aardelean@deviqon.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent af3bac44

drivers/iio/industrialio-buffer.c

+1 −0
Original line number Diff line number Diff line
@@ -1309,6 +1309,7 @@ static struct attribute *iio_buffer_wrap_attr(struct iio_buffer *buffer, 
	iio_attr->buffer = buffer;

	memcpy(&iio_attr->dev_attr, dattr, sizeof(iio_attr->dev_attr));

	iio_attr->dev_attr.attr.name = kstrdup_const(attr->name, GFP_KERNEL);

	sysfs_attr_init(&iio_attr->dev_attr.attr);



	list_add(&iio_attr->l, &buffer->buffer_attr_list);