Commit cc043428 authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (9685): gspca: Correct restart of webcams in spca501. 



Currently the spca501 driver only works the first time used, then the cam needs
to be unplugged or the driver reloaded, this is because currently the data
which should be send each time the stream is started is send only once.
Likewise currently the data to initialize the cam is send from the probe
function, and thus will not get send after a suspend/resume.
This patch fixes this by sending both at the right time.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarJean-Francois Moine <moinejf@free.fr>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent dff369aa

drivers/media/video/gspca/spca501.c

+12 −10
Original line number Diff line number Diff line
@@ -1930,6 +1930,14 @@ static int sd_config(struct gspca_dev *gspca_dev, 
	sd->contrast = sd_ctrls[MY_CONTRAST].qctrl.default_value;

	sd->colors = sd_ctrls[MY_COLOR].qctrl.default_value;



	return 0;

}



/* this function is called at probe and resume time */

static int sd_init(struct gspca_dev *gspca_dev)

{

	struct sd *sd = (struct sd *) gspca_dev;



	switch (sd->subtype) {

	case Arowana300KCMOSCamera:

	case SmileIntlCamera:
@@ -1948,15 +1956,17 @@ static int sd_config(struct gspca_dev *gspca_dev, 
			goto error;

		break;

	}

	PDEBUG(D_STREAM, "Initializing SPCA501 finished");

	return 0;

error:

	return -EINVAL;

}



/* this function is called at probe and resume time */

static int sd_init(struct gspca_dev *gspca_dev)

static int sd_start(struct gspca_dev *gspca_dev)

{

	struct sd *sd = (struct sd *) gspca_dev;

	struct usb_device *dev = gspca_dev->dev;

	int mode;



	switch (sd->subtype) {

	case ThreeComHomeConnectLite:
@@ -1976,14 +1986,6 @@ static int sd_init(struct gspca_dev *gspca_dev) 
		/* Generic 501 open data */

		write_vector(gspca_dev, spca501_open_data);

	}

	PDEBUG(D_STREAM, "Initializing SPCA501 finished");

	return 0;

}



static int sd_start(struct gspca_dev *gspca_dev)

{

	struct usb_device *dev = gspca_dev->dev;

	int mode;



	/* memorize the wanted pixel format */

	mode = gspca_dev->cam.cam_mode[(int) gspca_dev->curr_mode].priv;