Unverified Commit cc5d8ac9 authored by zhangqilong's avatar zhangqilong Committed by Mark Brown
Browse files

ASoC: rockchip: Fix PM usage reference of rockchip_i2s_tdm_resume 



pm_runtime_get_sync will increment pm usage counter
even it failed. Forgetting to putting operation will
result in reference leak here. We fix it by replacing
it with pm_runtime_resume_and_get to keep usage counter
balanced.

Fixes:081068fd ("ASoC: rockchip: add support for i2s-tdm controller")

Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20220315025415.2593762-1-zhangqilong3@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d39664cb

sound/soc/rockchip/rockchip_i2s_tdm.c

+1 −1
Original line number Diff line number Diff line
@@ -1738,7 +1738,7 @@ static int __maybe_unused rockchip_i2s_tdm_resume(struct device *dev) 
	struct rk_i2s_tdm_dev *i2s_tdm = dev_get_drvdata(dev);

	int ret;



	ret = pm_runtime_get_sync(dev);

	ret = pm_runtime_resume_and_get(dev);

	if (ret < 0)

		return ret;

	ret = regcache_sync(i2s_tdm->regmap);