Unverified Commit cd9ba3d0 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

ASoC: dt-bindings: qcom,apr: Correct and extend example 



Correct the APR/GPR example:
1. Use consistent 4-space indentation,
2. Add required properties to services nodes, so the binding check
   passes once schema for these services is improved,
3. Add few other properties as APR/GPR is part of a GLINK edge:
   qcom,glink-channels and qcom,intents.
4. Drop unnecessary services, to make the example compact.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20221115120235.167812-4-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 41288c30

Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml

+39 −22
Original line number Diff line number Diff line
@@ -142,6 +142,8 @@ examples: 
    apr {

        compatible = "qcom,apr-v2";

        qcom,domain = <APR_DOMAIN_ADSP>;

        qcom,glink-channels = "apr_audio_svc";

        qcom,intents = <512 20>;

        #address-cells = <1>;

        #size-cells = <0>;
@@ -151,22 +153,24 @@ examples: 
            qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";

        };



        q6afe: service@4 {

        service@4 {

            compatible = "qcom,q6afe";

            reg = <APR_SVC_AFE>;

            qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";

        };



        q6asm: service@7 {

          compatible = "qcom,q6asm";

          reg = <APR_SVC_ASM>;

          qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";

            clock-controller {

                compatible = "qcom,q6afe-clocks";

                #clock-cells = <2>;

            };



        q6adm: service@8 {

          compatible = "qcom,q6adm";

          reg = <APR_SVC_ADM>;

          qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";

            dais {

                compatible = "qcom,q6afe-dais";

                #address-cells = <1>;

                #size-cells = <0>;

                #sound-dai-cells = <1>;

                /* ... */

            };

            /* ... */

        };

    };
@@ -175,12 +179,25 @@ examples: 
    gpr {

        compatible = "qcom,gpr";

        qcom,domain = <GPR_DOMAIN_ID_ADSP>;

        qcom,glink-channels = "adsp_apps";

        qcom,intents = <512 20>;

        #address-cells = <1>;

        #size-cells = <0>;



        service@1 {

            compatible = "qcom,q6apm";

            reg = <GPR_APM_MODULE_IID>;

            #sound-dai-cells = <0>;

            qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";



            dais {

                compatible = "qcom,q6apm-dais";

                iommus = <&apps_smmu 0x1801 0x0>;

            };



            bedais {

                compatible = "qcom,q6apm-lpass-dais";

                #sound-dai-cells = <1>;

            };

        };

    };