Commit cde2f928 authored by Konrad Dybcio's avatar Konrad Dybcio Committed by Georgi Djakov
Browse files

interconnect: qcom: sm8250: Fix QUP0 nodes 



The QUP0 BCM relates to some internal property of the QUPs, and should
be configured independently of the path to the QUP. In line with other
platforms expose QUP_CORE endpoints in order allow this configuration.

Fixes: 6df5b349 ("interconnect: qcom: Add SM8250 interconnect provider driver")
Signed-off-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230703-topic-8250_qup_icc-v2-3-9ba0a9460be2@linaro.org


Signed-off-by: default avatarGeorgi Djakov <djakov@kernel.org>
parent ddd6c5b9

drivers/interconnect/qcom/sm8250.c

+71 −3
Original line number Diff line number Diff line
@@ -164,6 +164,54 @@ DEFINE_QNODE(xs_pcie_modem, SM8250_SLAVE_PCIE_2, 1, 8); 
DEFINE_QNODE(xs_qdss_stm, SM8250_SLAVE_QDSS_STM, 1, 4);

DEFINE_QNODE(xs_sys_tcu_cfg, SM8250_SLAVE_TCU, 1, 8);



static struct qcom_icc_node qup0_core_master = {

	.name = "qup0_core_master",

	.id = SM8250_MASTER_QUP_CORE_0,

	.channels = 1,

	.buswidth = 4,

	.num_links = 1,

	.links = { SM8250_SLAVE_QUP_CORE_0 },

};



static struct qcom_icc_node qup1_core_master = {

	.name = "qup1_core_master",

	.id = SM8250_MASTER_QUP_CORE_1,

	.channels = 1,

	.buswidth = 4,

	.num_links = 1,

	.links = { SM8250_SLAVE_QUP_CORE_1 },

};



static struct qcom_icc_node qup2_core_master = {

	.name = "qup2_core_master",

	.id = SM8250_MASTER_QUP_CORE_2,

	.channels = 1,

	.buswidth = 4,

	.num_links = 1,

	.links = { SM8250_SLAVE_QUP_CORE_2 },

};



static struct qcom_icc_node qup0_core_slave = {

	.name = "qup0_core_slave",

	.id = SM8250_SLAVE_QUP_CORE_0,

	.channels = 1,

	.buswidth = 4,

};



static struct qcom_icc_node qup1_core_slave = {

	.name = "qup1_core_slave",

	.id = SM8250_SLAVE_QUP_CORE_1,

	.channels = 1,

	.buswidth = 4,

};



static struct qcom_icc_node qup2_core_slave = {

	.name = "qup2_core_slave",

	.id = SM8250_SLAVE_QUP_CORE_2,

	.channels = 1,

	.buswidth = 4,

};



DEFINE_QBCM(bcm_acv, "ACV", false, &ebi);

DEFINE_QBCM(bcm_mc0, "MC0", true, &ebi);

DEFINE_QBCM(bcm_sh0, "SH0", true, &qns_llcc);
@@ -172,7 +220,7 @@ DEFINE_QBCM(bcm_ce0, "CE0", false, &qxm_crypto); 
DEFINE_QBCM(bcm_mm1, "MM1", false, &qnm_camnoc_hf, &qxm_mdp0, &qxm_mdp1);

DEFINE_QBCM(bcm_sh2, "SH2", false, &alm_gpu_tcu, &alm_sys_tcu);

DEFINE_QBCM(bcm_mm2, "MM2", false, &qns_mem_noc_sf);

DEFINE_QBCM(bcm_qup0, "QUP0", false, &qhm_qup1, &qhm_qup2, &qhm_qup0);

DEFINE_QBCM(bcm_qup0, "QUP0", false, &qup0_core_master, &qup1_core_master, &qup2_core_master);

DEFINE_QBCM(bcm_sh3, "SH3", false, &qnm_cmpnoc);

DEFINE_QBCM(bcm_mm3, "MM3", false, &qnm_camnoc_icp, &qnm_camnoc_sf, &qnm_video0, &qnm_video1, &qnm_video_cvp);

DEFINE_QBCM(bcm_sh4, "SH4", false, &chm_apps);
@@ -193,7 +241,6 @@ DEFINE_QBCM(bcm_sn11, "SN11", false, &qnm_gemnoc); 
DEFINE_QBCM(bcm_sn12, "SN12", false, &qns_pcie_modem_mem_noc, &qns_pcie_mem_noc);



static struct qcom_icc_bcm * const aggre1_noc_bcms[] = {

	&bcm_qup0,

	&bcm_sn12,

};
@@ -222,10 +269,29 @@ static const struct qcom_icc_desc sm8250_aggre1_noc = { 


static struct qcom_icc_bcm * const aggre2_noc_bcms[] = {

	&bcm_ce0,

	&bcm_qup0,

	&bcm_sn12,

};



static struct qcom_icc_bcm * const qup_virt_bcms[] = {

	&bcm_qup0,

};



static struct qcom_icc_node *qup_virt_nodes[] = {

	[MASTER_QUP_CORE_0] = &qup0_core_master,

	[MASTER_QUP_CORE_1] = &qup1_core_master,

	[MASTER_QUP_CORE_2] = &qup2_core_master,

	[SLAVE_QUP_CORE_0] = &qup0_core_slave,

	[SLAVE_QUP_CORE_1] = &qup1_core_slave,

	[SLAVE_QUP_CORE_2] = &qup2_core_slave,

};



static const struct qcom_icc_desc sm8250_qup_virt = {

	.nodes = qup_virt_nodes,

	.num_nodes = ARRAY_SIZE(qup_virt_nodes),

	.bcms = qup_virt_bcms,

	.num_bcms = ARRAY_SIZE(qup_virt_bcms),

};



static struct qcom_icc_node * const aggre2_noc_nodes[] = {

	[MASTER_A2NOC_CFG] = &qhm_a2noc_cfg,

	[MASTER_QDSS_BAM] = &qhm_qdss_bam,
@@ -518,6 +584,8 @@ static const struct of_device_id qnoc_of_match[] = { 
	  .data = &sm8250_mmss_noc},

	{ .compatible = "qcom,sm8250-npu-noc",

	  .data = &sm8250_npu_noc},

	{ .compatible = "qcom,sm8250-qup-virt",

	  .data = &sm8250_qup_virt },

	{ .compatible = "qcom,sm8250-system-noc",

	  .data = &sm8250_system_noc},

	{ }

drivers/interconnect/qcom/sm8250.h

+6 −0
Original line number Diff line number Diff line
@@ -158,5 +158,11 @@ 
#define SM8250_SLAVE_VSENSE_CTRL_CFG		147

#define SM8250_SNOC_CNOC_MAS			148

#define SM8250_SNOC_CNOC_SLV			149

#define SM8250_MASTER_QUP_CORE_0		150

#define SM8250_MASTER_QUP_CORE_1		151

#define SM8250_MASTER_QUP_CORE_2		152

#define SM8250_SLAVE_QUP_CORE_0			153

#define SM8250_SLAVE_QUP_CORE_1			154

#define SM8250_SLAVE_QUP_CORE_2			155



#endif