Unverified Commit cec5ccef authored by Francesco Dolcini's avatar Francesco Dolcini Committed by Robert Foss
Browse files

drm/bridge: tc358768: Add atomic_get_input_bus_fmts() implementation 



Add atomic_get_input_bus_fmts() implementation, tc358768 has a parallel
RGB input interface with the actual bus format depending on the amount
of parallel input data lines.

Without this change when the tc358768 is used with less than 24bit the
color mapping is completely wrong.

Signed-off-by: default avatarFrancesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: default avatarRobert Foss <rfoss@kernel.org>
Signed-off-by: default avatarRobert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230330095941.428122-7-francesco@dolcini.it
parent b2751a4c

drivers/gpu/drm/bridge/tc358768.c

+44 −0
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ 
#include <linux/gpio/consumer.h>

#include <linux/i2c.h>

#include <linux/kernel.h>

#include <linux/media-bus-format.h>

#include <linux/module.h>

#include <linux/regmap.h>

#include <linux/regulator/consumer.h>
@@ -913,6 +914,44 @@ static void tc358768_bridge_enable(struct drm_bridge *bridge) 
	}

}



#define MAX_INPUT_SEL_FORMATS	1



static u32 *

tc358768_atomic_get_input_bus_fmts(struct drm_bridge *bridge,

				   struct drm_bridge_state *bridge_state,

				   struct drm_crtc_state *crtc_state,

				   struct drm_connector_state *conn_state,

				   u32 output_fmt,

				   unsigned int *num_input_fmts)

{

	struct tc358768_priv *priv = bridge_to_tc358768(bridge);

	u32 *input_fmts;



	*num_input_fmts = 0;



	input_fmts = kcalloc(MAX_INPUT_SEL_FORMATS, sizeof(*input_fmts),

			     GFP_KERNEL);

	if (!input_fmts)

		return NULL;



	switch (priv->pd_lines) {

	case 16:

		input_fmts[0] = MEDIA_BUS_FMT_RGB565_1X16;

		break;

	case 18:

		input_fmts[0] = MEDIA_BUS_FMT_RGB666_1X18;

		break;

	default:

	case 24:

		input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24;

		break;

	};



	*num_input_fmts = MAX_INPUT_SEL_FORMATS;



	return input_fmts;

}



static const struct drm_bridge_funcs tc358768_bridge_funcs = {

	.attach = tc358768_bridge_attach,

	.mode_valid = tc358768_bridge_mode_valid,
@@ -920,6 +959,11 @@ static const struct drm_bridge_funcs tc358768_bridge_funcs = { 
	.enable = tc358768_bridge_enable,

	.disable = tc358768_bridge_disable,

	.post_disable = tc358768_bridge_post_disable,



	.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,

	.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,

	.atomic_reset = drm_atomic_helper_bridge_reset,

	.atomic_get_input_bus_fmts = tc358768_atomic_get_input_bus_fmts,

};



static const struct drm_bridge_timings default_tc358768_timings = {