Commit cf18fce4 authored by Ben Dooks's avatar Ben Dooks Committed by Bjorn Helgaas
Browse files

PCI: fu740: Drop redundant '-gpios' from DT GPIO lookup 

The calls to devm_gpiod_get_optional() have the -gpios at the end of the
name but the GPIO core code is already adding the suffix during the lookup.
This means the PCIe driver is not finding the necessary reset or power
lines to allow initialisation of the PCIe.

Drop the redundant '-gpios' when we look up GPIOs from the DT.

This bug has not been noticed because if U-Boot has setup the GPIO lines
for the hardware when it does the PCIe initialisation (either by booting
from PCIe or user command to access PCIe) then the PCIe will work in Linux.
The U-Boot as supplied by SiFive does not by default initialise any PCIe
component.

Link: https://lore.kernel.org/r/20220221210347.1335004-1-ben.dooks@codethink.co.uk


Signed-off-by: default avatarBen Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent e783362e

drivers/pci/controller/dwc/pcie-fu740.c

+2 −2
Original line number Diff line number Diff line
@@ -259,11 +259,11 @@ static int fu740_pcie_probe(struct platform_device *pdev) 
		return PTR_ERR(afp->mgmt_base);



	/* Fetch GPIOs */

	afp->reset = devm_gpiod_get_optional(dev, "reset-gpios", GPIOD_OUT_LOW);

	afp->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);

	if (IS_ERR(afp->reset))

		return dev_err_probe(dev, PTR_ERR(afp->reset), "unable to get reset-gpios\n");



	afp->pwren = devm_gpiod_get_optional(dev, "pwren-gpios", GPIOD_OUT_LOW);

	afp->pwren = devm_gpiod_get_optional(dev, "pwren", GPIOD_OUT_LOW);

	if (IS_ERR(afp->pwren))

		return dev_err_probe(dev, PTR_ERR(afp->pwren), "unable to get pwren-gpios\n");