Commit cf5fbe02 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

USB: apple-mfi-fastcharge: Fix use after free in probe 



This code frees "mfi" and then derefences it on the next line to get
the error code.

Fixes: b0eec52f ("USB: apple-mfi-fastcharge: Fix kfree after failed kzalloc")
Reviewed-by: default avatarBastien Nocera <hadess@hadess.net>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/X8ik4j8yJitVUyfU@mwanda


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ebad4326

drivers/usb/misc/apple-mfi-fastcharge.c

+3 −1
Original line number Diff line number Diff line
@@ -178,6 +178,7 @@ static int mfi_fc_probe(struct usb_device *udev) 
{

	struct power_supply_config battery_cfg = {};

	struct mfi_device *mfi = NULL;

	int err;



	if (!mfi_fc_match(udev))

		return -ENODEV;
@@ -194,8 +195,9 @@ static int mfi_fc_probe(struct usb_device *udev) 
						&battery_cfg);

	if (IS_ERR(mfi->battery)) {

		dev_err(&udev->dev, "Can't register battery\n");

		err = PTR_ERR(mfi->battery);

		kfree(mfi);

		return PTR_ERR(mfi->battery);

		return err;

	}



	mfi->udev = usb_get_dev(udev);