Commit d0513776 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Helge Deller
Browse files

fbdev: metronomefb: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 3a2ab02d

drivers/video/fbdev/metronomefb.c

+2 −3
Original line number Diff line number Diff line
@@ -744,7 +744,7 @@ static int metronomefb_probe(struct platform_device *dev) 
	return retval;

}



static int metronomefb_remove(struct platform_device *dev)

static void metronomefb_remove(struct platform_device *dev)

{

	struct fb_info *info = platform_get_drvdata(dev);
@@ -761,12 +761,11 @@ static int metronomefb_remove(struct platform_device *dev) 
		dev_dbg(&dev->dev, "calling release\n");

		framebuffer_release(info);

	}

	return 0;

}



static struct platform_driver metronomefb_driver = {

	.probe	= metronomefb_probe,

	.remove = metronomefb_remove,

	.remove_new = metronomefb_remove,

	.driver	= {

		.name	= "metronomefb",

	},