Commit d06130dc authored by Colin Ian King's avatar Colin Ian King Committed by Takashi Iwai
Browse files

ALSA: hdsp: remove redundant assignment to pointer kctl 



Pointer kctl is being assigned a value that is not being read, buf
is being re-assigned later. The assignment is redundant and can be
removed.

Cleans up clang scan build warning:
sound/pci/rme9652/hdsp.c:3317:28: warning: Although the value stored
to 'kctl' is used in the enclosing expression, the value is never
actually read from 'kctl' [deadcode.DeadStores]

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20220508212819.59188-1-colin.i.king@gmail.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ca348e7f

sound/pci/rme9652/hdsp.c

+1 −1
Original line number Diff line number Diff line
@@ -3314,7 +3314,7 @@ static int snd_hdsp_create_controls(struct snd_card *card, struct hdsp *hdsp) 
	if (hdsp->io_type == RPM) {

		/* RPM Bypass, Disconnect and Input switches */

		for (idx = 0; idx < ARRAY_SIZE(snd_hdsp_rpm_controls); idx++) {

			err = snd_ctl_add(card, kctl = snd_ctl_new1(&snd_hdsp_rpm_controls[idx], hdsp));

			err = snd_ctl_add(card, snd_ctl_new1(&snd_hdsp_rpm_controls[idx], hdsp));

			if (err < 0)

				return err;

		}