Commit d0f90841 authored by Kees Cook's avatar Kees Cook
Browse files

checkpatch: Check for strcpy and strncpy too 



Warn about strcpy(), strncpy(), and strlcpy(). Suggest strscpy() and
include pointers to the open KSPP issues for each, which has further
details and replacement procedures.

Cc: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230517201349.never.582-kees@kernel.org
parent d0c2d66f

scripts/checkpatch.pl

+13 −1
Original line number Original line Diff line number Diff line
@@ -6997,10 +6997,22 @@ sub process { 
#			}

#			}

#		}

#		}





# strcpy uses that should likely be strscpy

		if ($line =~ /\bstrcpy\s*\(/) {

			WARN("STRCPY",

			     "Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88\n" . $herecurr);

		}



# strlcpy uses that should likely be strscpy

# strlcpy uses that should likely be strscpy

		if ($line =~ /\bstrlcpy\s*\(/) {

		if ($line =~ /\bstrlcpy\s*\(/) {

			WARN("STRLCPY",

			WARN("STRLCPY",

			     "Prefer strscpy over strlcpy - see: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw\@mail.gmail.com/\n" . $herecurr);

			     "Prefer strscpy over strlcpy - see: https://github.com/KSPP/linux/issues/89\n" . $herecurr);

		}



# strncpy uses that should likely be strscpy or strscpy_pad

		if ($line =~ /\bstrncpy\s*\(/) {

			WARN("STRNCPY",

			     "Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90\n" . $herecurr);

		}

		}





# typecasts on min/max could be min_t/max_t

# typecasts on min/max could be min_t/max_t