Commit d3beaf18 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Jonathan Cameron
Browse files

iio: gyro: mpu3050: Make mpu3050_common_remove() return void 



This function (up to now) returns zero unconditionally, so there isn't
any benefit of returning a value. Make it return void to be able to see
at a glance that the return value of mpu3050_i2c_remove is always zero.

This patch is a preparation for making i2c remove callbacks return void.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20220425191735.59032-1-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent a9d1a34f

drivers/iio/gyro/mpu3050-core.c

+1 −3
Original line number Diff line number Diff line
@@ -1263,7 +1263,7 @@ int mpu3050_common_probe(struct device *dev, 
}

EXPORT_SYMBOL(mpu3050_common_probe);



int mpu3050_common_remove(struct device *dev)

void mpu3050_common_remove(struct device *dev)

{

	struct iio_dev *indio_dev = dev_get_drvdata(dev);

	struct mpu3050 *mpu3050 = iio_priv(indio_dev);
@@ -1276,8 +1276,6 @@ int mpu3050_common_remove(struct device *dev) 
		free_irq(mpu3050->irq, mpu3050);

	iio_device_unregister(indio_dev);

	mpu3050_power_down(mpu3050);



	return 0;

}

EXPORT_SYMBOL(mpu3050_common_remove);

drivers/iio/gyro/mpu3050-i2c.c

+3 −1
Original line number Diff line number Diff line
@@ -86,7 +86,9 @@ static int mpu3050_i2c_remove(struct i2c_client *client) 
	if (mpu3050->i2cmux)

		i2c_mux_del_adapters(mpu3050->i2cmux);



	return mpu3050_common_remove(&client->dev);

	mpu3050_common_remove(&client->dev);



	return 0;

}



/*

drivers/iio/gyro/mpu3050.h

+1 −1
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ int mpu3050_common_probe(struct device *dev, 
			 struct regmap *map,

			 int irq,

			 const char *name);

int mpu3050_common_remove(struct device *dev);

void mpu3050_common_remove(struct device *dev);



/* PM ops */

extern const struct dev_pm_ops mpu3050_dev_pm_ops;