Commit d4d13ff3 authored by Jiri Slaby (SUSE)'s avatar Jiri Slaby (SUSE) Committed by Greg Kroah-Hartman
Browse files

tty: tty_buffer: switch data type to u8 



There is no reason to have tty_buffer::data typed as unsigned long.
Switch to u8, but preserve the ulong alignment using __aligned.

This allows for the cast removal from char_buf_ptr(). And for use of
struct_size() in the allocation in tty_buffer_alloc() -- in the next
patch.

Signed-off-by: default avatar"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230816105530.3335-2-jirislaby@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2f492672

include/linux/tty_buffer.h

+2 −2
Original line number Diff line number Diff line
@@ -19,12 +19,12 @@ struct tty_buffer { 
	unsigned int read;

	bool flags;

	/* Data points here */

	unsigned long data[];

	u8 data[] __aligned(sizeof(unsigned long));

};



static inline u8 *char_buf_ptr(struct tty_buffer *b, unsigned int ofs)

{

	return ((u8 *)b->data) + ofs;

	return b->data + ofs;

}



static inline u8 *flag_buf_ptr(struct tty_buffer *b, unsigned int ofs)