Commit d6393793 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915/audio: Don't enable audio with bogus ELD 



Currently we just print a debug message if the ELD is bogus.
Maybe we should just not enable audio at all in that case?

Cc: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Cc: Takashi Iwai <tiwai@suse.de>
Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230124144628.4649-6-ville.syrjala@linux.intel.com
parent 5d986635

drivers/gpu/drm/i915/display/intel_audio.c

+3 −1
Original line number Diff line number Diff line
@@ -757,10 +757,12 @@ bool intel_audio_compute_config(struct intel_encoder *encoder, 
	const struct drm_display_mode *adjusted_mode =

		&crtc_state->hw.adjusted_mode;



	if (!connector->eld[0])

	if (!connector->eld[0]) {

		drm_dbg_kms(&i915->drm,

			    "Bogus ELD on [CONNECTOR:%d:%s]\n",

			    connector->base.id, connector->name);

		return false;

	}



	BUILD_BUG_ON(sizeof(crtc_state->eld) != sizeof(connector->eld));

	memcpy(crtc_state->eld, connector->eld, sizeof(crtc_state->eld));