Commit d65305bf authored by Rob Herring's avatar Rob Herring Committed by Michael Ellerman
Browse files

powerpc: 52xx: Make immr_id DT match tables static 



In some builds, the mpc52xx_pm_prepare()/lite5200_pm_prepare() functions
generate stack size warnings. The addition of 'struct resource' in commit
2500763d ("powerpc: Use of_address_to_resource()") grew the stack size
and is blamed for the warnings. However, the real issue is there's no
reason the 'struct of_device_id immr_ids' DT match tables need to be on
the stack as they are constant. Declare them as static to move them off
the stack.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202306130405.uTv5yOZD-lkp@intel.com/


Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230614171724.2403982-1-robh@kernel.org
parent ef8e3410

arch/powerpc/platforms/52xx/lite5200_pm.c

+1 −1
Original line number Diff line number Diff line
@@ -47,7 +47,7 @@ static int lite5200_pm_begin(suspend_state_t state) 
static int lite5200_pm_prepare(void)

{

	struct device_node *np;

	const struct of_device_id immr_ids[] = {

	static const struct of_device_id immr_ids[] = {

		{ .compatible = "fsl,mpc5200-immr", },

		{ .compatible = "fsl,mpc5200b-immr", },

		{ .type = "soc", .compatible = "mpc5200", }, /* lite5200 */

arch/powerpc/platforms/52xx/mpc52xx_pm.c

+1 −1
Original line number Diff line number Diff line
@@ -60,7 +60,7 @@ int mpc52xx_set_wakeup_gpio(u8 pin, u8 level) 
int mpc52xx_pm_prepare(void)

{

	struct device_node *np;

	const struct of_device_id immr_ids[] = {

	static const struct of_device_id immr_ids[] = {

		{ .compatible = "fsl,mpc5200-immr", },

		{ .compatible = "fsl,mpc5200b-immr", },

		{ .type = "soc", .compatible = "mpc5200", }, /* lite5200 */