Commit d729163d authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf symbol: Use zfree() to reduce chances of use after free 



Do defensive programming by using zfree() to initialize freed pointers
to NULL, so that eventual use after free result in a NULL pointer deref
instead of more subtle behaviour.

Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent b20c6308

tools/perf/util/symbol-elf.c

+2 −2
Original line number Diff line number Diff line
@@ -396,7 +396,7 @@ static bool get_ifunc_name(Elf *elf, struct dso *dso, GElf_Ehdr *ehdr, 


static void exit_rel(struct rel_info *ri)

{

	free(ri->sorted);

	zfree(&ri->sorted);

}



static bool get_plt_sizes(struct dso *dso, GElf_Ehdr *ehdr, GElf_Shdr *shdr_plt,
@@ -460,7 +460,7 @@ struct rela_dyn_info { 


static void exit_rela_dyn(struct rela_dyn_info *di)

{

	free(di->sorted);

	zfree(&di->sorted);

}



static int cmp_offset(const void *a, const void *b)