Commit d85deed4 authored Oct 15, 2022 by Sergey Shtylyov Committed by Andrew Morton Nov 15, 2022

ia64: ptrace: user_regset_copyin_ignore() always returns 0

user_regset_copyin_ignore() always returns 0, so checking its result seems
pointless -- don't do this anymore...

Link: https://lkml.kernel.org/r/20221014212235.10770-6-s.shtylyov@omp.ru

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Brian Cain <bcain@quicinc.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: David S. Miller <davem@davemloft.net>
Cc: Dinh Nguyen <dinguyen@kernel.org>
Cc: Helge Deller <deller@gmx.de>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jonas Bonn <jonas@southpole.se>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Rich Felker <dalias@libc.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Stafford Horne <shorne@gmail.com>
Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Will Deacon <will@kernel.org>
Cc: Yoshinori Sato <ysato@users.osdn.me>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

parent 4d2cfea8

arch/ia64/kernel/ptrace.c

+9 −11

Original line number	Diff line number	Diff line
		@@ -1481,12 +1481,10 @@ static void do_gpregs_set(struct unw_frame_info info, void arg)
		return;
		/* Skip r0 */
		if (dst->pos < ELF_GR_OFFSET(1)) {
		dst->ret = user_regset_copyin_ignore(&dst->pos, &dst->count,
		&dst->u.set.kbuf,
		&dst->u.set.ubuf,
		user_regset_copyin_ignore(&dst->pos, &dst->count,
		&dst->u.set.kbuf, &dst->u.set.ubuf,
		0, ELF_GR_OFFSET(1));
		if (dst->ret)
		return;
		dst->ret = 0;
		}

		while (dst->count && dst->pos < ELF_AR_END_OFFSET) {
		@@ -1560,11 +1558,11 @@ static void do_fpregs_set(struct unw_frame_info info, void arg)

		/* Skip pos 0 and 1 */
		if (dst->count > 0 && dst->pos < ELF_FP_OFFSET(2)) {
		dst->ret = user_regset_copyin_ignore(&dst->pos, &dst->count,
		&dst->u.set.kbuf,
		&dst->u.set.ubuf,
		user_regset_copyin_ignore(&dst->pos, &dst->count,
		&dst->u.set.kbuf, &dst->u.set.ubuf,
		0, ELF_FP_OFFSET(2));
		if (dst->count == 0 \|\| dst->ret)
		dst->ret = 0;
		if (dst->count == 0)
		return;
		}