Commit d89edb36 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Saeed Mahameed
Browse files

net/mlx5: Remove impossible checks of interface state 



The interface state is constant at this stage and checked
before calling to the register/unregister reserved GIDs.

There is no need to double check it.

Reviewed-by: default avatarMoshe Shemesh <moshe@nvidia.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 7bef147a

drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c

+0 −5
Original line number Diff line number Diff line
@@ -55,10 +55,6 @@ void mlx5_cleanup_reserved_gids(struct mlx5_core_dev *dev) 


int mlx5_core_reserve_gids(struct mlx5_core_dev *dev, unsigned int count)

{

	if (test_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state)) {

		mlx5_core_err(dev, "Cannot reserve GIDs when interfaces are up\n");

		return -EPERM;

	}

	if (dev->roce.reserved_gids.start < count) {

		mlx5_core_warn(dev, "GID table exhausted attempting to reserve %d more GIDs\n",

			       count);
@@ -79,7 +75,6 @@ int mlx5_core_reserve_gids(struct mlx5_core_dev *dev, unsigned int count) 


void mlx5_core_unreserve_gids(struct mlx5_core_dev *dev, unsigned int count)

{

	WARN(test_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state), "Unreserving GIDs when interfaces are up");

	WARN(count > dev->roce.reserved_gids.count, "Unreserving %u GIDs when only %u reserved",

	     count, dev->roce.reserved_gids.count);